Trump is right that McKinley played a critical role in American history, but not for the reasons Trump articulates.